[FFmpeg-devel] [PATCH 1/1] vf_drawtext.c: remove duplicate av_expr_eval() line

[Michael Niedermayer]

On Wed, Feb 01, 2012 at 06:21:42PM +0100, Nicolas Noirbent wrote:
> ---
>  libavfilter/vf_drawtext.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/libavfilter/vf_drawtext.c b/libavfilter/vf_drawtext.c
> index d0d854b..0d88e68 100644
> --- a/libavfilter/vf_drawtext.c
> +++ b/libavfilter/vf_drawtext.c
> @@ -819,7 +819,6 @@ static int draw_text(AVFilterContext *ctx, AVFilterBufferRef *picref,
>  
>      dtext->x = dtext->var_values[VAR_X] = av_expr_eval(dtext->x_pexpr, dtext->var_values, &dtext->prng);
>      dtext->y = dtext->var_values[VAR_Y] = av_expr_eval(dtext->y_pexpr, dtext->var_values, &dtext->prng);
> -    dtext->x = dtext->var_values[VAR_X] = av_expr_eval(dtext->x_pexpr, dtext->var_values, &dtext->prng);
>      dtext->draw = av_expr_eval(dtext->d_pexpr, dtext->var_values, &dtext->prng);

this is intentionally "duplicate"
so that each expression can refer to the result of the other (but
not both at the same time)


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120201/51cc14e5/attachment.asc>