[FFmpeg-devel] [PATCH] web: add g+ badge that links to FFmpeg page on g+
Alexander Strasser
eclipse7 at gmx.net
Sun Dec 30 22:22:54 CET 2012
Lou Logan wrote:
> On Sun, 30 Dec 2012 19:45:40 +0000, Paul B Mahol wrote:
>
> > ---
> > src/index | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/src/index b/src/index
> > index 72063c7..1f0084c 100644
> > --- a/src/index
> > +++ b/src/index
> > @@ -31,7 +31,8 @@ with the latest developments by subscribing to both the
> > </p>
> >
> >
> > -<h1>News <a href="main.rss"><img style="vertical-align: middle; margin-left: 6px" src="Feed-icon.png" alt="[RSS]" /></a></h1>
> > +<h1>News <a href="main.rss"><img style="vertical-align: middle; margin-left: 6px" src="Feed-icon.png" alt="[RSS]" /></a><a href="https://plus.google.com/108003112428040046828?prsrc=3" rel="publisher" style="text-decoration:none;">
> > +<img src="https://ssl.gstatic.com/images/icons/gplus-16.png" alt="Google+" style="vertical-align: middle; margin-left: 16px"/></a></h1>
>
> nit: For consistency: '16px"; />'
> Although don't waste your time with that unless others have suggestions.
>
> I'm a social media hermit, and ignorant of g+, but technically LGTM
> assuming you looked at it in-browser.
>
> If we get more badge things I think a better place for non-news icons
> would be on the far right side of "Project Description" as I mentioned
> on IRC.
I looked at it in-browser and W3C validation was also fine. So LGTM.
Alexander
More information about the ffmpeg-devel
mailing list