[FFmpeg-devel] [PATCH]Animated gif transparency - second attempt to patch

[Paul B Mahol]

On 12/30/12, Don Moir <donmoir at comcast.net> wrote:
> On the first go around, Paul had modified the patch I submitted to use
> background_color_index instead of the
> transparent_color_index.
>
> This is incorrect since the background_color_index has nothing to do with
> transparency
>
> So looking at the following code:
>
>          if (s->gce_disposal == GCE_DISPOSAL_BACKGROUND) {
> -            if (s->background_color_index >= 0)
> +            if (s->transparent_color_index >= 0)
>                  s->stored_bg_color = s->trans_color;
>              else
>                  s->stored_bg_color = s->bg_color;
>
> This sample has a background_color_index >= 0 but has no transparency. So if
> you test for background_color_index >= 0, it will be
> wrong. The correct behavior is to test for transparent_color_index >= 0.
>
> http://sms.pangolin.com/temp/gold_non_transparent.gif
>
> If you display this in a browser chances are it will be shown incorrectly.
>
> As the star rotates, the background color should be gold and not transparent
> or black. IE and FireFox show it as transparent. Opera
> showed it as a black background. The other 3rd partly programs I used showed
> it correctly with gold background.
>
> Shown here correctly as star rotates:
>
> http://sms.pangolin.com/temp/gold_shown_correct.png
>
> Please re-apply
>

Applied, Sorry for not doing this first time.

The original patch did not apply (neither this one), was not produced
with git. So I failed in manual patching that time which is really
embarassing