[FFmpeg-devel] [PATCH] Megalux Frame muxer and demuxer

[Carl Eugen Hoyos]

Peter Ross <pross <at> xvid.org> writes:

> +const AVCodecTag ff_frm_pix_fmt_tags[] = {
> +    { PIX_FMT_RGB555, 1 },
> +    { PIX_FMT_BGR32,  2 },
> +    { PIX_FMT_RGB24,  3 },
> +    { PIX_FMT_BGRA,   4 },

> +    { PIX_FMT_BGRA,   5 },

Only from looking at the hexdump of your uploaded sample:
Shouldn't this be BGR0 (at least for "5"?
Or is the sample meant to be completely transparent?

[...]

> +static int frm_read_probe(AVProbeData *p)
> +{
> +    if (p->buf_size > 8 &&
> +        p->buf[0] == 'F' && p->buf[1] == 'R' && p->buf[2] == 'M' &&
> +        AV_RL16(&p->buf[4]) && AV_RL16(&p->buf[6]))
> +        return AVPROBE_SCORE_MAX;

I suspect MAX is too much for 24bit plus two of four bytes != 0.

Carl Eugen