[FFmpeg-devel] [PATCH 1/2] lavfi/video: ensure that filter_frame is called.

[Nicolas George]

Le septidi 7 nivôse, an CCXXI, Michael Niedermayer a écrit :
> after pull --rebase and both patches:
> make fate-lavfi-tile
> ==12655== Invalid read of size 8
<snip>
> Assertion link->cur_buf_copy->buf->refcount > 0 failed at libavfilter/video.c:381

I am sorry, but I am still unable to reproduce the issue. I am working with
the following tree, without local changes:

ae69e57 lavfi/sink_buffer: switch to filter_frame.
909e799 lavfi/video: ensure that filter_frame is called.
9e04e11 libpostproc: alloc a few bytes more in the temporary buffer
f1185fb libpostproc: Fix off by 1 error in the C dering code
69db85c mjpegdec: Support 16bit DQT

9e04e11 is currently the head of the official repository, and AFAIK the
(short) hash uniquely identifies the whole tree anyway (except for unlikely
collisions. I tried both this and with only 909e799, with or without
valgrind on x86_64, and x86_32, and fate-lavfi-tile (and the rest of FATE)
succeeds.

(Still, I see a small flaw in the patch: it should not be clearing
link->cur_buf before the call because some filter may still use it. Do your
tree include "4cd724d lavfi/tile: remove usage of link->{cur,out}_buf."?)

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121228/dd6cef58/attachment.asc>