[FFmpeg-devel] [PATCH]Set sample_aspect_ratio in real demuxer

[Nicolas George]

Le decadi 30 frimaire, an CCXXI, Carl Eugen Hoyos a écrit :
> Isn't this an independent bug?

I do not think so. If there is a bug at work here, it may be to set
codec->width and codec->height from these fields in the container. Do you
know whether there is an authoritative documentation available?

> What I want to fix is that ffmpeg -i file shows 
> "unknown DAR" while it is actually known.

I know you want to fix that, but that precise fix is invalid and causes
worse problems later, i.e. an invalid aspect ratio instead of an unknown
one.

> Do you think there is a situation where is does not work?

I had just given an example.


As a side note, IIRC, Git commit messages are supposed to be "context: short
summary\n\nLonger summary if necessary." In this particular case, that would
be something like "lavf/rmdec: set sample_aspect_ratio".

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121220/059c9393/attachment.asc>