[FFmpeg-devel] [PATCH] doc/texi2pod: rework man inclusion logic

[Derek Buitenhuis]

On 16/12/2012 11:48 AM, Stefano Sabatini wrote:
> Ignore @c man begin ... @c man end comments, rely on @chapter for marking
> the beginning of the various manual sections.
> 
> This allows to write markup which is not depending on the specific
> texi2pod.pl implementation.

s/allows/allows us/ && s/depending/dependent/

> This change causes a bit rendering issues, which will be fixed in further
> patches.

Do you plan to wait for those before you push?

> -    # Look for blocks surrounded by @c man begin SECTION ... @c man end.
> -    # This really oughta be @ifman ... @end ifman and the like, but such
> -    # would require rev'ing all other Texinfo translators.
> -    /^\@c\s+man\s+begin\s+([A-Za-z ]+)/ and $sect = $1, push (@sects_sequence, $sect), $output = 1, next;
> -    /^\@c\s+man\s+end/ and do {
> -        $sects{$sect} = "" unless exists $sects{$sect};
> -        $sects{$sect} .= postprocess($section);
> -        $section = "";
> -        $output = 0;
> +    /^\@chapter\s+([A-Za-z ]+)/ and do {

Don't plan to support numbers in chapter names? (It might be forbidden by the spec,
for all I know.)

> +        # close old chapter
> +        $chapters{$chapter_name} .= postprocess($chapter) if ($chapter_name);
> +
> +        # start new chapter
> +        $chapter_name = $1, push (@chapters_sequence, $chapter_name);

I'm not actually familiar with this particular pattern (the way comma is used).

Rest seems OK, mostly being s/sect/chapter/.

The script still scares me, though. ;)

- Derek