[FFmpeg-devel] patches for dshow: handle events in graph andCoUninitialize

Ramiro Polla ramiro.polla at gmail.com
Thu Dec 13 23:45:41 CET 2012


Hi,

On Thu, Dec 13, 2012 at 8:06 PM, Don Moir <donmoir at comcast.net> wrote:
> ----- Original Message ----- From: "Carl Eugen Hoyos" <cehoyos at ag.or.at>
> To: <ffmpeg-devel at ffmpeg.org>
> Sent: Thursday, December 13, 2012 4:46 PM
>> Don Moir <donmoir <at> comcast.net> writes:
>>> There is one more thing that needs to change but probably best to commit
>>> these patches first in order to avoid confusion.
>>
>>
>> Please send a proper patch (made with git format-patch or git send-email)
>> and I will apply.
>>
>> Carl Eugen
>>
>
> Ramiro may want to modify his patch and resubmit.
> Again, dshow_read_close(avctx); needs to be removed from dshow_add_device
>
>
> So in dshow_add_device:
>
>        if (codec->pix_fmt == AV_PIX_FMT_NONE) {
>            codec->codec_id = dshow_codecid(bih->biCompression);
>            if (codec->codec_id == AV_CODEC_ID_NONE) {
>                av_log(avctx, AV_LOG_ERROR, "Unknown compression type. "
>                                 "Please report verbose (-v 9) debug
> information.\n");
> // remove dshow_read_close - its not needed and can cause trouble
> -                dshow_read_close(avctx);
>                return AVERROR_PATCHWELCOME;
>            }
>            codec->bits_per_coded_sample = bih->biBitCount;
>        } else _______________________________________________

Here's the updated patch (to replace 0003-*** from the other thread).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-dshow-call-CoUninitialize-on-dshow_read_close.patch
Type: application/octet-stream
Size: 2017 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121213/da2f225d/attachment.obj>


More information about the ffmpeg-devel mailing list