[FFmpeg-devel] [PATCH] lavfi: add aselect audio variant of select

[Clément Bœsch]

On Tue, Dec 11, 2012 at 11:22:56PM +0100, Stefano Sabatini wrote:
> TODO: add Changelog entry, bump minor
> ---
>  doc/filters.texi         |   20 +++++++--
>  libavfilter/Makefile     |    1 +
>  libavfilter/allfilters.c |    1 +
>  libavfilter/vf_select.c  |  106 +++++++++++++++++++++++++++++++++++++---------
>  4 files changed, 104 insertions(+), 24 deletions(-)
> 
> diff --git a/doc/filters.texi b/doc/filters.texi
> index b840cac..fefc2af 100644
> --- a/doc/filters.texi
> +++ b/doc/filters.texi
[...]
> - at item scene
> + at item scene @emph{(only video)}

nit++: "video only"? (and "audio only")

>  value between 0 and 1 to indicate a new scene; a low value reflects a low
>  probability for the current frame to introduce a new scene, while a higher
>  value means the current frame is more likely to be one (see the example below)
> @@ -3617,6 +3626,9 @@ select='gte(t\,10)*lte(t\,20)*eq(pict_type\,I)'
>  
>  # select frames with a minimum distance of 10 seconds
>  select='isnan(prev_selected_t)+gte(t-prev_selected_t\,10)'
> +
> +# use aselect to select only audio frames with samples number > 100
> +aselect='gt(samples_n, 100)'

Please stick with the surrounding escaping until we decide what to do with
them.

[...]

The code LGTM.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121212/75a4c7ea/attachment.asc>