[FFmpeg-devel] [PATCH] astenc: Add an option to set the loop flag

[Carl Eugen Hoyos]

jamal <jamrial <at> gmail.com> writes:

> -    if (ast->loopstart && ast->loopend && ast->loopstart >= ast->loopend) {
> -        av_log(s, AV_LOG_ERROR, "loopend can't be less or equal to 
> loopstart\n");
> -        return AVERROR(EINVAL);
> -    }
> -
> -    /* Convert milliseconds to samples */
> -    CHECK_LOOP(start)
> -    CHECK_LOOP(end)

> +        if (ast->loopend && ast->loopstart >= ast->loopend) {
> +            av_log(s, AV_LOG_ERROR, "loopend can't be less or equal to 
> loopstart\n");
> +            return AVERROR(EINVAL);
> +        }
> +        /* Convert milliseconds to samples */
> +        CHECK_LOOP(start)
> +        CHECK_LOOP(end)

Please do not re-indent these lines, it makes the review 
unnecessarily more difficult.

Sorry for not answering your last mail:
I wondered if values like "-1" cannot be used to indicate 
"no loop"?

Carl Eugen