[FFmpeg-devel] [PATCH 2/6] lavu/channel_layout: implement unknown layouts.

[Nicolas George]

Le duodi 12 frimaire, an CCXXI, Michael Niedermayer a écrit :
> > - Having layout != 0 but still |layout| != nb_channels is not a good idea,
> >   as it goes against the principle of least surprise. (Being able to flag
> >   dual-mono as MONO is not worth it, especially since 2 channels +
> >   layout=unknown can hardly be anything else.)
> it can be stereo as well.
> unknown just says unknown not that its not a known standard format

That is true. But the base question still stands: on one hand, the guarantee
that |layout| = nb_channels if it is known (which a lot of developers will
assume spontaneously), on the other hand, the possibility of flagging
dual-mono as mono (while 5.1+mono still can not): which one do you consider
more important?

My opinion is that the first one is more important.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121202/013b57d0/attachment.asc>