[FFmpeg-devel] [PATCH] lavc/dvdsubdec: accept palette from options.

[Reimar Döffinger]

On Sat, Dec 01, 2012 at 05:22:44PM +0100, Nicolas George wrote:
> Le primidi 11 frimaire, an CCXXI, Reimar Döffinger a écrit :
> > Usually you would copy the IFO as well.
> > I guess making FFmpeg use that IFO might be more difficult
> > than just adding this option though.
> 
> Probably. Also, inventing a palette by trial-and-error is easy, inventing an
> IFO file is hard.

Which is why MPlayer etc. support "ifo" files that only contain
text-format palette I guess :-)

> >		   (which of course leads to the question if we shouldn't
> > just have an option to set/replace the extradata).
> 
> I do not have any objection to that.

I'm not that good with the option system though.
Also it would help if it was possible to specify it both as text string
or hex values, do we have something like that already?

> dvdsub_parse_extradata() can fail if ENOMEM, this is IMHO not something that
> should be ignored.

I somehow missed the malloc is moved into the parse extradata, sorry
about that.