[FFmpeg-devel] [PATCH]Flip zerocodec

[Derek Buitenhuis]

On 30/11/2012 8:47 PM, Carl Eugen Hoyos wrote:
> Hi!
> 
> Attached patch fixes ticket #1218 for me.

Patch is wrong. The problem has nothing to do with ZeroCodec really.

The way several VFW codecs signal bottup-up RGB is to use a negative height.

This is handled incorrectly/insanely (read: extradata hacks for specific a codec)
in our AVI demuxer, AFAIK.

Furthermore, depending on which OS is used to decode or encode ZeroCodec, it
will be flagged correctly or incorrectly, and may or may not be bottum-up RGB.

These is simply no 'correct' patch. The way ZeroCodec currently behaves is based
on an OS to which is was intended to be used (given the year it was written).

As the author of zercodec.c, I reject this patch yet again (this is the first
time someone has tried this.)

If you wish, I can fish out very extensive IRC logs from when we investigated it originally.

- Derek