[FFmpeg-devel] [PATCH] lswr/swresample: use AV_OPT_TYPE_SAMPLE_FMT for sample format options

[Michael Niedermayer]

On Sat, Dec 01, 2012 at 12:13:18AM +0100, Stefano Sabatini wrote:
> On date Friday 2012-11-30 04:24:42 +0100, Michael Niedermayer encoded:
> > On Fri, Nov 30, 2012 at 01:11:14AM +0100, Stefano Sabatini wrote:
> > > Improve usability and robustness. This is technically an API/ABI break.
> > 
> > please elaborate why this is a API/ABI break, so i dont misunderstand
> > the implications by mistake
> 
> With OPT_*_FMT I'm not setting min and max (are set to 0), so
> opt.c:write_number() fails with an out-of-range.
> 
> I could set the range to [-1, FMT_NB-1] and fix it if you think it is
> a good idea.

the min and max certainly should be set
also they should be checked by all ways to set

consider AV_SAMPLE_FMT_NONE, the min/max is the only way to know if
its allowed

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121201/45d230ec/attachment.asc>