[FFmpeg-devel] [PATCH 1/2] Add 'rw_timeout' into URLContext

Michael Niedermayer michaelni at gmx.at
Thu Aug 30 05:01:54 CEST 2012


On Wed, Aug 29, 2012 at 10:51:18AM +0300, Andrey Utkin wrote:
> 2012/8/29 Nicolas George <nicolas.george at normalesup.org>:
> > #define AVERROR_TIMEOUT FFERRTAG('T','M','O','U')
> >
> > Bonus: it allows to distinguish a timeout requested to lavf from a timeout
> > issued from the network layer.
> 
> Valid variant. Although i don't agree on goodness of having distinct
> retcodes both meaning timeout.

we could replace all usees of ETIMEDOUT


> Also in my perception, AVERROR_xxx constant should be defined only if
> standard Exxx does not exist (only AVERROR_INVALIDDATA breaks my
> rule).

should a Exxx be considered standard if it doesnt exist on a major
platform.
Also theres another problem, we can define ETIMEDOUT in a private
header to something and use it but how is a user application supposed
to make sense of the return code then ? it has no ETIMEDOUT

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120830/4dfb8758/attachment.asc>


More information about the ffmpeg-devel mailing list