[FFmpeg-devel] [PATCH] Add missing codec descriptor for timingless subrip.

[Nicolas George]

Le duodi 12 fructidor, an CCXX, Philip Langdale a écrit :
> Signed-off-by: Philip Langdale <philipl at overt.org>
> ---
>  libavcodec/codec_desc.c |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c
> index dd4870d..25d9d8f 100644
> --- a/libavcodec/codec_desc.c
> +++ b/libavcodec/codec_desc.c
> @@ -2052,6 +2052,12 @@ static const AVCodecDescriptor codec_descriptors[] = {
>          .id        = AV_CODEC_ID_SRT,
>          .type      = AVMEDIA_TYPE_SUBTITLE,
>          .name      = "srt",
> +        .long_name = NULL_IF_CONFIG_SMALL("SubRip Text with embedded timing"),
> +    },
> +    {
> +        .id        = AV_CODEC_ID_SUBRIP,
> +        .type      = AVMEDIA_TYPE_SUBTITLE,
> +        .name      = "subrip",
>          .long_name = NULL_IF_CONFIG_SMALL("SubRip Text"),
>      },
>      {

The encoders and decoders have "SubRip subtitle with embedded timing" and
"SubRip subtitle": I believe it would be better consistent. Apart from that
LGTM.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120829/af015432/attachment.asc>