[FFmpeg-devel] [PATCH] doc/examples: add scaling_video example

Alexander Strasser eclipse7 at gmx.net
Tue Aug 28 19:31:24 CEST 2012


Hi Stefano,

Stefano Sabatini wrote:
> On date Friday 2012-08-24 16:25:32 +0200, Stefano Sabatini encoded:
> > On date Thursday 2012-08-23 20:30:45 +0200, Michael Niedermayer encoded:
> [...]
> > > iam not sure init+allo+free for every scaleing is a good idea for an
> > > example, it could lead to the wrong impression on what has to be done
> > > per picture
> > 
> > OK.
> > 
> > So it might work this way:
> > - generate synthetic images
> > - convert/rescale them to GRAY8
> > - print to PGM files
> 
> Updated.

  Nice work! I guess a sample like this is often requested.

  Some minor problem: after you changed the program as you
described above, it would be nice if it was somehow documented
what the code does; especially considering it is sample code.
Might be enough to adjust the usage message.

  Maybe something in the line of:
|
| This program generates a series of pictures, rescales them
| to the given <output size> and finally saves the rescaled
| pictures as PGM files named like outscale<frame number>.pgm.

  I am sure you can improve on my first clumsy attempt, but I
hope you get the idea of my concern.

[...]

  Alexander


More information about the ffmpeg-devel mailing list