[FFmpeg-devel] [PATCH] lavc: fix build when optimizations are disabled

[Stefano Sabatini]

On date Monday 2012-08-27 17:01:20 +0200, Michael Niedermayer encoded:
> On Mon, Aug 27, 2012 at 01:22:20PM +0200, Stefano Sabatini wrote:
> > ---
> >  libavcodec/dnxhdenc.c      |    2 +-
> >  libavcodec/mpegvideo.c     |    2 +-
> >  libavcodec/mpegvideo_enc.c |    2 +-
> >  3 files changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/libavcodec/dnxhdenc.c b/libavcodec/dnxhdenc.c
> > index 24767fd..273186d 100644
> > --- a/libavcodec/dnxhdenc.c
> > +++ b/libavcodec/dnxhdenc.c
> > @@ -294,7 +294,7 @@ static int dnxhd_encode_init(AVCodecContext *avctx)
> >         ctx->block_width_l2 = 3;
> >      }
> >  
> > -    if (ARCH_X86)
> > +    if (ARCH_X86 && HAVE_MMX)
> >          ff_dnxhdenc_init_x86(ctx);
> 
> IMHO its either mmx or x86 but calling it _x86 and then only using
> when mmx is enabled isnt good
> 
> also HAVE_MMX implicates ARCH_X86

Simplified. This fixes compilation for me, and yes I agree _mmx seemed
a more meaningful names but I don't feel like I want to introduce more
potentially pointless renames.
-- 
FFmpeg = Fantastic and Frightening Miracolous Patchable Encoding/decoding Gadget
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lavc-fix-build-when-optimizations-are-disabled.patch
Type: text/x-diff
Size: 1968 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120828/66d7cd52/attachment.bin>