[FFmpeg-devel] [PATCH] lavfi: add flags to filter specific options

[Stefano Sabatini]

On date Thursday 2012-08-16 14:15:21 +0200, Stefano Sabatini encoded:
> On date Monday 2012-08-13 13:09:50 +0200, Stefano Sabatini encoded:
[...]
> > Anyone willing to comment on this?
> > 
> > Note: I followed two distinct styles in the patch:
> > 1.
> > #define A AV_OPT_FLAG_AUDIO_PARAM
> > #define A AV_OPT_FLAG_FILTERING_PARAM
> > ...
> > { "sample_fmts",     "A comma-separated list of sample formats.", OFFSET(formats_str), AV_OPT_TYPE_STRING, .flags=F|A },
> > 
> > 2.
> > #define FLAGS .flags=AV_OPT_FLAG_AUDIO_PARAM|AV_OPT_FLAG_FILTERING_PARAM
> > ...
> > { "sample_fmts",     "A comma-separated list of sample formats.", OFFSET(formats_str), AV_OPT_TYPE_STRING, FLAGS },
> > 
> > I switched from 1. to 2. (which I slightly prefer) when editing the
> > patch, but I can switch back to 1. if people prefer that.
> > 
> > Problems: iteration over component classes requires that no filters
> > can share the same class, so I'll need to duplicate the shared classes
> > (relevant in lut and movie).
> 
> I'll push this patch today if I read no objections, please comment.

Applied.
-- 
FFmpeg = Freak & Fancy Muttering Perfectionist Erroneous Gladiator