[FFmpeg-devel] [PATCH] cmdutils: poison released video buffers.

Michael Niedermayer michaelni at gmx.at
Sat Aug 18 01:39:20 CEST 2012


On Fri, Aug 17, 2012 at 06:12:28PM +0200, Nicolas George wrote:
> 
> Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
> ---
>  cmdutils.c |   13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> 
> It breaks the followinf FATE tests:
> 
> lavfi-overlay
> filter-yadif-mode0
> filter-yadif-mode1
> h264-conformance-frext-hpcamolq_brcm_b
> h264-conformance-frext-hpcvmolq_brcm_b
> tscc-15bit
> tscc-32bit
> id-cin-video
> mpeg2-field-enc
> 
> Unless I am completely mistaken about what get_buffer/release_buffer are
> supposed to do, this is the sign of real bugs.

release_buffer() just means that the decoder does not need the buffer
anymore, it doesnt mean that the application doesnt.
The buffer could be in some que waiting to be displayed while the
decoder calls release_buffer()

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120818/06c03c80/attachment.asc>


More information about the ffmpeg-devel mailing list