[FFmpeg-devel] [PATCH]Support 16 channel audio in lxf

[Reimar Döffinger]

On Thu, Aug 16, 2012 at 08:29:28AM +0000, Carl Eugen Hoyos wrote:
> Reimar Döffinger <Reimar.Doeffinger <at> gmx.de> writes:
> 
> > On 14 Aug 2012, at 00:31, Carl Eugen Hoyos wrote:
> > > Carl Eugen Hoyos <cehoyos <at> ag.or.at> writes:
> > > 
> > >> Attached patch (partly) fixes ticket #1608 for me.
> > > 
> > > I will apply the patch if nobody objects.
> 
> Sorry, I had missed Reimar's answer and pushed.
> 
> > Could you maybe explain what the new value calculation 
> > is supposed to mean? I can't really make any sense of 
> > it at the moment.
> 
> The old code assumed that four bits in the datastream 
> contain the number of audio channels.
> Looking at the provided samples, two bits show the number 
> of channels, channels = 2 ^ (two_bits + 1)
> (allowing 2, 4, 8 and 16 channels)
> 
> Do you want me to revert?

No, but it seems strange that common formats like 6 channels etc.
can't be encoded like that.
Also, doesn't the compiler print a warning and want you to add an
extra () round the + in the shift argument?