[FFmpeg-devel] [PATCH] movie: set pkt->stream_index for flushing.

[Nicolas George]

Le decadi 30 thermidor, an CCXX, Stefano Sabatini a écrit :
> Nit on the patch name:
> lavfi/movie: set pkt->stream_index for flushing
> 
> useful for log grepping purposes.
> 
> On date Tuesday 2012-08-14 11:16:51 +0200, Nicolas George encoded:
> > Otherwise, the value is kept from the last read,
> 
> which value, what is intended by "last read"?

Enhanced and pushed.

> Should be fine but I'm having an hard time at understanding the
> movie_push_frame() logic with regards to the movie->pkt field
> (documenting the out_id parameter may also help).

I sent a patch for out_id.

> An alternative would be to create a pkt_stream_idx separate variable
> and use it in:
> 
>     pkt_out_id = pkt->stream_index > movie->max_stream_index ? -1 :
>                  movie->out_index[pkt->stream_index];

I find it more awkward.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120816/cfac1911/attachment.asc>