[FFmpeg-devel] [PATCH] ffplay: reque attached pictures on channel changes.

Michael Niedermayer michaelni at gmx.at
Thu Aug 16 04:40:51 CEST 2012


On Wed, Aug 15, 2012 at 10:59:16PM +0200, Marton Balint wrote:
> 
> 
> On Wed, 15 Aug 2012, Michael Niedermayer wrote:
> 
> >Fixes Ticket1473
> >
> >Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> >---
> >ffplay.c |    6 ++++++
> >1 file changed, 6 insertions(+)
> >
> >diff --git a/ffplay.c b/ffplay.c
> >index 282d56f..a04a5b3 100644
> >--- a/ffplay.c
> >+++ b/ffplay.c
> >@@ -141,6 +141,7 @@ typedef struct VideoState {
> >    int force_refresh;
> >    int paused;
> >    int last_paused;
> >+    int que_attachments_req;
> >    int seek_req;
> >    int seek_flags;
> >    int64_t seek_pos;
> >@@ -2503,6 +2504,10 @@ static int read_thread(void *arg)
> >            is->seek_req = 0;
> >            eof = 0;
> >        }
> >+        if (is->que_attachments_req) {
> >+            avformat_queue_attached_pictures(ic);
> >+            is->que_attachments_req = 0;
> >+        }
> >
> >        /* if the queue are full, no need to read more */
> >        if (!infinite_buffer &&
> >@@ -2680,6 +2685,7 @@ static void stream_cycle_channel(VideoState *is, int codec_type)
> > the_end:
> >    stream_component_close(is, old_index);
> >    stream_component_open(is, stream_index);
> >+    is->que_attachments_req = 1;
> 
> Is there a reason to set this when codec_type != AVMEDIA_TYPE_VIDEO ?

no, fixed


> Otherwise LGTM.

applied, thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you think the mosad wants you dead since a long time then you are either
wrong or dead since a long time.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120816/751e4ea1/attachment.asc>


More information about the ffmpeg-devel mailing list