[FFmpeg-devel] [PATCH] lavf: F3M spec, muxer, demuxer and tools. (WIP)

[Michael Niedermayer]

On Sat, Aug 04, 2012 at 08:19:45PM +0200, Nicolas George wrote:
> 
> Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
> ---
>  doc/f3m.txt              |   75 ++++++++++
>  libavformat/Makefile     |    2 +
>  libavformat/allformats.c |    1 +
>  libavformat/f3m.c        |   54 +++++++
>  libavformat/f3mdec.c     |  359 ++++++++++++++++++++++++++++++++++++++++++++++
>  libavformat/f3menc.c     |  316 ++++++++++++++++++++++++++++++++++++++++
>  6 files changed, 807 insertions(+)
>  create mode 100644 doc/f3m.txt
>  create mode 100644 libavformat/f3m.c
>  create mode 100644 libavformat/f3mdec.c
>  create mode 100644 libavformat/f3menc.c
> 
> 
> This is the format that I was writing about a few days ago: it allows to
> remux almost anything and to extract a portion of the file very fast.
> 
> This is not finished: the extra tools are missing (especially the one that
> can extract a part using hardlinks) and some more testing is required (at
> least I would like to try MPlayer), but it already works.
> 
> The design is the same that has been privately used for two years, with
> minor fixes and enhancements.
> 
> The goal of the format design is to keep things simple. I would like to know
> if deep changes will be necessary before starting to port the tools.

the code should be ok, testing it with a fuzzer to make sure it doenst
crash or end in infinite loops cant hurt though

iam not reviewing the design because if i want to
improve some container format, i would work on nut and i think
others similarly should concentrate their efforts on making nut the
best design instead of spliting the effort between f3m, nut and ffm

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120815/eb4743a0/attachment.asc>