[FFmpeg-devel] [PATCH] Add ICO muxer

[Michael Niedermayer]

On Sun, Aug 12, 2012 at 10:30:45AM -0600, Michael Bradshaw wrote:
> On Sun, Aug 12, 2012 at 10:27 AM, Michael Bradshaw
> <mbradshaw at sorensonmedia.com> wrote:
> > New version is attached (it also has Michael Neidermayer's requested fix).
> 
> Sorry to keep spamming. I just found a comment I don't want in that
> patch. I've attached the a new version of the patch.
> 
> Thanks for the reviews!
> 
> --Michael

>  Changelog                |    1 
>  doc/general.texi         |    2 
>  doc/muxers.texi          |   33 +++++++
>  libavformat/Makefile     |    1 
>  libavformat/allformats.c |    2 
>  libavformat/icoenc.c     |  204 +++++++++++++++++++++++++++++++++++++++++++++++
>  6 files changed, 241 insertions(+), 2 deletions(-)
> 38cfda9aa36414171f0aa95a579a747dfba7d95e  0001-Add-ICO-muxer.patch
> From 05d4f5f1a69a92dfab488f7a794131a5e48f7951 Mon Sep 17 00:00:00 2001
> From: Michael Bradshaw <mbradshaw at sorensonmedia.com>
> Date: Sun, 12 Aug 2012 10:29:36 -0600
> Subject: [PATCH] Add ICO muxer
> 
> Signed-off-by: Michael Bradshaw <mbradshaw at sorensonmedia.com>

applied

a regression test could/should be added too

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120814/74e185dc/attachment.asc>