[FFmpeg-devel] [PATCH] lavu/opt.h: add AV_OPT_FLAG_FILTERING_PARAM macro

[Michael Niedermayer]

On Sat, Aug 11, 2012 at 12:02:54PM +0200, Stefano Sabatini wrote:
> On date Friday 2012-08-10 00:59:39 +0200, Michael Niedermayer encoded:
> > On Thu, Aug 09, 2012 at 11:00:32PM +0200, Stefano Sabatini wrote:
> > > ---
> > >  libavutil/opt.c |    1 +
> > >  libavutil/opt.h |    2 ++
> > >  2 files changed, 3 insertions(+), 0 deletions(-)
> > > 
> > > diff --git a/libavutil/opt.c b/libavutil/opt.c
> > > index 02869e4..0adbddd 100644
> > > --- a/libavutil/opt.c
> > > +++ b/libavutil/opt.c
> > > @@ -634,6 +634,7 @@ static void opt_list(void *obj, void *av_log_obj, const char *unit,
> > >          }
> > >          av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_ENCODING_PARAM) ? 'E' : '.');
> > >          av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_DECODING_PARAM) ? 'D' : '.');
> > > +        av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_FILTERING_PARAM)? 'F' : '.');
> > >          av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_VIDEO_PARAM   ) ? 'V' : '.');
> > >          av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_AUDIO_PARAM   ) ? 'A' : '.');
> > >          av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_SUBTITLE_PARAM) ? 'S' : '.');
> > > diff --git a/libavutil/opt.h b/libavutil/opt.h
> > > index b947814..76b8bcd 100644
> > > --- a/libavutil/opt.h
> > > +++ b/libavutil/opt.h
> > > @@ -279,6 +279,8 @@ typedef struct AVOption {
> > >  #define AV_OPT_FLAG_AUDIO_PARAM     8
> > >  #define AV_OPT_FLAG_VIDEO_PARAM     16
> > >  #define AV_OPT_FLAG_SUBTITLE_PARAM  32
> > 
> > > +#define AV_OPT_FLAG_FILTERING_PARAM 64
> > 
> > maybe this should be more distant from the largest flag so it doesnt
> > start oddly conflicting with something from the fork
> 
> Upped.
> -- 
> FFmpeg = Fundamental Fundamental Multimedia Practical Elastic Generator

>  opt.c |    1 +
>  opt.h |    2 ++
>  2 files changed, 3 insertions(+)
> 1d39f520fd25459fecebaed4cf4155b2ccf69a45  0003-lavu-opt.h-add-AV_OPT_FLAG_FILTERING_PARAM-macro.patch
> From edea00aa24565eec9ba52e8e00ed67a55f08be0b Mon Sep 17 00:00:00 2001
> From: Stefano Sabatini <stefasab at gmail.com>
> Date: Thu, 9 Aug 2012 16:21:07 +0200
> Subject: [PATCH] lavu/opt.h: add AV_OPT_FLAG_FILTERING_PARAM macro
> 
> ---
>  libavutil/opt.c |    1 +
>  libavutil/opt.h |    2 ++
>  2 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/libavutil/opt.c b/libavutil/opt.c
> index 02869e4..0adbddd 100644
> --- a/libavutil/opt.c
> +++ b/libavutil/opt.c
> @@ -634,6 +634,7 @@ static void opt_list(void *obj, void *av_log_obj, const char *unit,
>          }
>          av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_ENCODING_PARAM) ? 'E' : '.');
>          av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_DECODING_PARAM) ? 'D' : '.');
> +        av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_FILTERING_PARAM)? 'F' : '.');
>          av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_VIDEO_PARAM   ) ? 'V' : '.');
>          av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_AUDIO_PARAM   ) ? 'A' : '.');
>          av_log(av_log_obj, AV_LOG_INFO, "%c", (opt->flags & AV_OPT_FLAG_SUBTITLE_PARAM) ? 'S' : '.');
> diff --git a/libavutil/opt.h b/libavutil/opt.h
> index b947814..1f4e1c6 100644
> --- a/libavutil/opt.h
> +++ b/libavutil/opt.h
> @@ -279,6 +279,8 @@ typedef struct AVOption {
>  #define AV_OPT_FLAG_AUDIO_PARAM     8
>  #define AV_OPT_FLAG_VIDEO_PARAM     16
>  #define AV_OPT_FLAG_SUBTITLE_PARAM  32
> +#define AV_OPT_FLAG_FILTERING_PARAM MKBETAG('F','I','L','T')

i dont think bitwise orring that together with other things will work

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Asymptotically faster algorithms should always be preferred if you have
asymptotical amounts of data
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120811/a37cce47/attachment.asc>