[FFmpeg-devel] [PATCH] lavf/img2dec: add -pattern_type option

[Stefano Sabatini]

On date Wednesday 2012-08-08 01:17:11 +0200, Stefano Sabatini encoded:
> On date Wednesday 2012-08-08 00:26:18 +0200, Alexander Strasser encoded:
> > Stefano Sabatini wrote:
> [...]
> > > + at var{pattern_type} can assume one of the following values.
> > 
> > nit: Not fully sure but "can assume" sounds a bit strange to my
> > non-native English ears.
> > 
> >   Quick list of alternatives that come to mind:
> > "accepts", "can be", "can take", "can be set to"
> 
> => accepts
> 
> > [...]
> > > + at item glob_sequence
> > > +Select a mixed glob wildcard/sequence pattern.
> > 
> >   If we really want to remove glob_sequence, then it is probably
> > a good idea to mention it here too.
> > 
> >   Maybe
> > 
> >   @item glob_sequence (deprecated, will be removed)
> > 
> > or similar.
> 
> It is already mentioned at the end of the paragraph, but I added an
> @emph warning right after the @item entry.
> 
> > [remaining patch snipped]
> > 
> >   The remaining parts look good AFAICT. I could not quickly test
> > as the patch doesn't apply cleanly for me. But assuming it works
> > for you and you tested it I would say it is push-ready (maybe
> > wait a little bit longer if someone else wants to comment).
> 
> Patch updated, will push it in one day or so if I read no more
> comments. 

[...]

Applied.
-- 
FFmpeg = Fundamental and Formidable Multimedia Puristic Evil Geisha