[FFmpeg-devel] [PATCH] ass subtitles: Fix valgrind warnings.

[Philip Langdale]

On Sun, 5 Aug 2012 18:07:10 +0200
Nicolas George <nicolas.george at normalesup.org> wrote:

> Actually, it is often more practical to work with pointer+len (or even
> better: pointer+end_pointer) than with 0-terminated strings.
> 
> But this would require a big rework; I just wanted to mention it for
> reference.

Totally agreed on both points.

> > +            av_free (ctx->field_order[i]);
> > +        }
> 
> Maybe av_freep to avoid leaving a dangling pointer: that may make life
> easier for someone else looking for another bug in the future.

Yeah, Clément also recommended that.

Thanks,

--phil