[FFmpeg-devel] [PATCH] enhance libvpx-configure-warning

[Michael Niedermayer]

On Sat, Aug 04, 2012 at 02:30:45AM +0200, Alexander Strasser wrote:
> Hi
> 
> Roger Pack wrote:
> > The current error message confused me at first:
> > ERROR: libvpx decoder version must be >=0.9.1
> > 
> > When in reality it meant "libvpx library not found"
> > patch attached.  Feel free to rephrase it if desired, or tell me to and I will.
> > Also this is my first patch to ffmpeg-devel, so please let me know if
> > there is any etiquette measures I missed.
> 
>   Thanks for the submission.
>  
> > diff --git a/configure b/configure
> > index 6cd170e..138df24 100755
> > --- a/configure
> > +++ b/configure
> > @@ -3447,7 +3447,7 @@ enabled libvo_amrwbenc && require libvo_amrwbenc vo-amrwbenc/enc_if.h E_IF_init
> >  enabled libvorbis  && require  libvorbis vorbis/vorbisenc.h vorbis_info_init -lvorbisenc -lvorbis -logg
> >  enabled libvpx     && {
> >      enabled libvpx_decoder && { check_lib2 "vpx/vpx_decoder.h vpx/vp8dx.h" vpx_codec_dec_init_ver -lvpx ||
> > -                                die "ERROR: libvpx decoder version must be >=0.9.1"; }
> > +                                die "ERROR: libvpx decoder version must be >=0.9.1, or libvpx library not found"; }
> 
>   IMHO this is shorter and better: die "ERROR: libvpx decoder version must be installed and >=0.9.1"; }
> 
> >      enabled libvpx_encoder && { check_lib2 "vpx/vpx_encoder.h vpx/vp8cx.h" "vpx_codec_enc_init_ver VP8E_SET_MAX_INTRA_BITRATE_PCT" -lvpx ||
> >                                  die "ERROR: libvpx encoder version must be >=0.9.7"; } }
> >  enabled libx264    && require  libx264 x264.h x264_encoder_encode -lx264 &&
> 
>   Looking at this I guess you would have the same problem with
> the encoder error message. So it would make sense to change all
> similar messages; speaking of which I doubt it is really worth it.
> Read the last paragraph below...
> 
>   On the one hand I share the thought that this might be confusing
> to the pure end-user. On the other hand most people would probably
> do like you and look up where the message originates. Then they
> will find out that it could be a rather existential problem as
> opposed to typical version mismatch. What do other developers think?
> 
>   Especially Michael, what is your opinion? As this would probably
> complicate your work when merging.

change it to whatever you consider better

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120804/ff0d5a2a/attachment.asc>