[FFmpeg-devel] [PATCH 2/3] textdec: Rename all generic parts from srt to text.

[Nicolas George]

Le sextidi 16 thermidor, an CCXX, Clément Bœsch a écrit :
> In SRT yes. For SAMI as I said it's based on the subtitles reader in
> MPlayer. And it wouldn't be a surprise to find more of them. I can try
> various subtitles editor and do some subtitles convert with them from ASS
> to another format, I'm pretty sure I'll be able to generate mixed markups,
> which will be btw "well" rendered in some players...

Creating broken files on purpose is always easy. I was wondering if such
files actually existed outside that.

> > My rationale to want TAGSOUP instead of SUBRIP is to make it clear when a
> > format is really specified or when it is parsed defensively to handle
> > anything in the wild.
> Well, this tagging system is better known as "SubRip" so I think it makes
> more sense to use that name...

No! I was not talking about SubRip, I was talking about SubRip+ASS.

> My point is that it should be in another pass.

Whether this is done in another pass or directly by the decoder using helper
functions is implementation detail.

> 1) If we keep the current state (the decoders directly convert markup to
>    ASS tags), we will need that each decoder access and honor a
>    -subtitles_escape_ass general option. During the process of converting
>    from markup to ass, { and } will need to be escaped or not. This is

Yes, but my point is that this option should be on by default in most
codecs.

>			and then convert it to the RAW format for subtitles
>    (ASS, right?).

What's this about a raw format? I do not understand what you are referring
to.

Things currently work like that:

file ----> AVPacket -----> AVSubtitle -----> AVPacket -----> file
     demux          decode            encode           mux

What I am suggesting in this thread is just to change the way the decoded
subtitle is stored in AVSubtitle, from ASS lines with timestamps and style
in a clumsy syntax to... what I described.

If people want ASS lines to feed libass, they can reconstruct it from
AVSubtitle. We will probably provide an API to do that because it is such a
common need and we will have to implement it to keep compatibility anyway.
But the ASS lines should not be stored in AVSubtitle or anywhere.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120802/e1ec17bc/attachment.asc>