[FFmpeg-devel] [PATCH 3/3] textdec: Add TEXT subtitle decoding mode.

[Nicolas George]

Le quintidi 15 thermidor, an CCXX, Philip Langdale a écrit :
> The concensus opinion seems to be that a TEXT decoder where we
> assume the packet contains pure text and timing information is
> carried in the packet pts/duration has value.
> 
> Given that the bulk of the work in this case is exactly the same
> as for SRT (only the time extraction is different), it seems
> reasonable for them to be in the same .c file.

This part looks right to me, assuming the srt/text decoder do the right
thing with regard to ASS, i.e. leave it alone.

You forgot the #ifdefs to allow enabling/disabling the decoders
individually, and the corresponding Makefile change, though.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120801/50b97534/attachment.asc>