[FFmpeg-devel] [PATCH] ffmpeg: insert bitmap subtitles as video in filters.

[Nicolas George]

Le quintidi 15 thermidor, an CCXX, Stefano Sabatini a écrit :
> Maybe mention what the funny labels stand for.

Added.

> Comment this block with something along the line:
> |Compute the size for the video subtitles stream. This will be the
> |subtitles stream size if defined, otherwise the minimum size which
> |will contain all the video streams specified in the corresponding
> |input file.
> or a shortened version.

Added too.

> Maybe you could complain and write only in the overlapping region.

I do not have a sample. I could probably fabricate one (although bitmap
subtitles are currently fragile and hard tu mux). But that would make more
complex code for possibly no real-world reason at all. I'll implement it if
someone has the problem and a sample.

> What's the implication of AV_BUFFERSRC_FLAG_NO_CHECK_FORMAT? (I mean
> can it happens that the size of the buffer changes, in that case what
> happens of the filtergraph?, can it cope with it?).

Currently, the size of the buffer can not change.

> nit: "inf" reminds "info", what about "infile"?

> nit: nb_reqs since it is plural

Changed.

> Please can you explain what this does?

Added comments.

> s->streams[i]->codec->codec_type could be factored.

Changed.

Thanks for the review, updated patch in a few minutes.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120801/d9812f63/attachment.asc>