[FFmpeg-devel] [PATCH 1/3] lavc: implement accessors for some AVFrame fields.

[Nicolas George]

Le primidi 11 floréal, an CCXX, Clément Bœsch a écrit :
> Yes but adding a bunch of getter/setter for a limited range of options
> might be confusing since the API gets inconsistent. Of course it's somehow
> already the case, but in the current state it appears like what it really
> is: a workaround for ABI issues. After the patch it looks more like
> helpers for users. That's the reason I was just raising the idea of
> extending this to every user configurable fields.

Speaking for myself:

I really dislike the object religion where you have to go through a method
just to change an integer, and one of the things I like about ffmpeg is that
it does not adhere to that religion.

For those few fields, the API is inconsistent indeed, but there are reasons
behind that, and we have to live with it. IMHO, better an API inconsistent
but mostly good than an API that is consistently bad.

And if there is a blame to put for the inconsistency, it is on the people
who may break the compatibility, exactly as if they introduced a new library
with a different name and naming convention doing the same job as one that
already exists...

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120429/6b21ee2a/attachment.asc>