[FFmpeg-devel] [PATCH 01/13] lavc: add a channel_layout field to AVFrame.

[Michael Niedermayer]

On Sat, Apr 28, 2012 at 04:31:43PM +0200, Nicolas George wrote:
> The field is filled with the codec context information.
> 
> FIXME need a minor version bump.
> 
> Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
> ---
>  libavcodec/avcodec.h |    8 ++++++++
>  libavcodec/utils.c   |    2 ++
>  2 files changed, 10 insertions(+), 0 deletions(-)
> 
> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> index c3a5192..a19e4ac 100644
> --- a/libavcodec/avcodec.h
> +++ b/libavcodec/avcodec.h
> @@ -1257,6 +1257,14 @@ typedef struct AVFrame {
>       * - decoding: Read by user.
>       */
>      int64_t pkt_pos;
> +
> +    /**
> +     * channel layout of the audio frame
> +     * - encoding: unused
> +     * - decoding: read by user.
> +     */
> +    int64_t channel_layout;

this probably should, like pkt_pos say:
 * Code outside libavcodec should access this field using:
 *  av_opt_ptr(avcodec_get_frame_class(), frame, "channel_layout");

also it should be added to the AVframe clas
otherwise LGTM


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120428/5bef719d/attachment.asc>