[FFmpeg-devel] [PATCH 1/2] lavfi: merge asrc_abuffer into vsrc_buffer.

[Nicolas George]

Le nonidi 9 floréal, an CCXX, Stefano Sabatini a écrit :
> Nit: config_output_video -> vsrc_config_output, consistent with
> sink_buffer.c. Same below.

Consistency is good, but I find more logical and readable to have similar
functions sharing a prefix and distinguished by a suffix instead of the
reverse. For example, the functions will be near to each other in a sorted
list.

> You can save a few KBs of unused binary code in case of disable by
> reorganizing the function order, putting under #ifdef those which
> are not shared (see sink_buffer.c).

Are you sure this is necessary? The compilers I know will print a warning
about an unused function (which is not a problem in an unusual
configuration) and drop the unused code.

Anyway, the next patches move that code to share more of it, and I believe
asrc_abuffer should become part of the public API just like vsrc_buffer is
already.

Thanks for the review.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120428/adae6561/attachment.asc>