[FFmpeg-devel] [PATCH] avfiltergraph: fix format selection.

[Michael Niedermayer]

On Mon, Apr 23, 2012 at 05:46:07PM +0200, Nicolas George wrote:
> The old code had two bugs:
> 
> For audio filters, the format was not set.
> 
> For video filters, if several links reference the same format list,
> the same format must be selected in the end. This is done by
> setting formats->format_count to 1: the other links sharing
> the reference will therefore have only one choice.
> If the heuristic does not pick the first format, the selected format
> must also be moved to the first position.
> 
> Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
> ---
>  libavfilter/avfiltergraph.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> 
> The bug was introduced by the following commit:
> 
> 0d115d7 avfiltergraph: More advanced heuristic to select colorspace.
> 
> It can be experienced using the following command:
> 
> ./ffmpeg_g -vcodec pgmyuv -i tests/vsynth1/00.pgm \
>   -vf format=yuv444p10,scale,crop,scale,format=yuv444p10 -f null -
> 
> Notice how the scale filters just before and just after crop do not have
> matching colorspace: the first converts to rgb48be and the second from
> yuv420p.

patch LGTM

thanks

[....]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 2
"100% positive feedback" - "All either got their money back or didnt complain"
"Best seller ever, very honest" - "Seller refunded buyer after failed scam"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120424/7a41f7dd/attachment.asc>