[FFmpeg-devel] [PATCH] Simplify asynth sample generation.

[Reimar Döffinger]

On Mon, Apr 23, 2012 at 10:13:54PM +0200, Michael Niedermayer wrote:
> On Mon, Apr 23, 2012 at 09:16:14PM +0200, Reimar Döffinger wrote:
> > On Mon, Apr 23, 2012 at 12:24:39AM +0200, Michael Niedermayer wrote:
> > > On Sun, Apr 22, 2012 at 07:15:47PM +0200, Reimar Döffinger wrote:
> > > > One rule can be used to generate all asynth files.
> > > > Requires renaming the mapchan files though.
> > > > Also switch to using the .wav variants for mapchan
> > > > while changing the name anyway, this allows getting rid
> > > > of the explicitly specified format.
> > > > 
> > > > Signed-off-by: Reimar Döffinger <Reimar.Doeffinger at gmx.de>
> > > > ---
> > > >  tests/Makefile         |   12 +-----------
> > > >  tests/fate/mapchan.mak |   12 ++++++------
> > > >  2 files changed, 7 insertions(+), 17 deletions(-)
> > > 
> > > LGTM
> > 
> > Pushed.
> 
> a make distclean configure make -j4 fate
> fails with:
> --- ./tests/ref/acodec/aref 2012-04-12 01:28:12.214975001 +0200
> +++ tests/data/fate/acodec-aref 2012-04-23 22:10:04.365516025 +0200
> @@ -1,4 +1,2 @@
>  64151e4bcc2b717aa5a8454d424d6a1f *./tests/data/acodec.ref.wav
>  1058446 ./tests/data/acodec.ref.wav
> -ce524631c2ad0a40aaab46e3a80a1176 *./tests/data/acodec-16000-1.ref.wav
> -192046 ./tests/data/acodec-16000-1.ref.wav
> Test acodec-aref failed. Look at tests/data/fate/acodec-aref.err for details.
> make: *** [fate-acodec-aref] Error 1
> make: *** Waiting for unfinished jobs....

This looks like a make bug to me, it seems to believe it generated the
file even though it never did (grepped for the two asynth files in the
-d log):
      Considering target file `tests/data/asynth1.sw'.
       File `tests/data/asynth1.sw' does not exist.
       Finished prerequisites of target file `tests/data/asynth1.sw'.
      The prerequisites of `tests/data/asynth1.sw' are being made.
      Considering target file `tests/data/asynth-16000-1.sw'.
       File `tests/data/asynth-16000-1.sw' does not exist.
       Looking for an implicit rule for `tests/data/asynth-16000-1.sw'.
       Found an implicit rule for `tests/data/asynth-16000-1.sw'.
       Finished prerequisites of target file `tests/data/asynth-16000-1.sw'.
      The prerequisites of `tests/data/asynth-16000-1.sw' are being made.
      Considering target file `tests/data/asynth1.sw'.
       File `tests/data/asynth1.sw' does not exist.
       Finished prerequisites of target file `tests/data/asynth1.sw'.
      Must remake target `tests/data/asynth1.sw'.
Obtained token for child 0x02671420 (tests/data/asynth1.sw).
Putting child 0x02671420 (tests/data/asynth1.sw) PID 13494 on the chain.
      Commands of `tests/data/asynth1.sw' are being run.
      Considering target file `tests/data/asynth-16000-1.sw'.
      File `tests/data/asynth-16000-1.sw' was considered already.

Of course it never says which implicit rule it chose, but the
dependencies match the right out, so that should be fine really.