[FFmpeg-devel] [PATCH] web: Copy FFmpeg Logo by Makefile instead of cronjob

[Reimar Döffinger]

On Sun, Apr 22, 2012 at 07:36:30PM +0200, Michael Niedermayer wrote:
> On Sat, Apr 21, 2012 at 08:22:40PM +0200, Thilo Borgmann wrote:
> > Am 19.04.12 19:18, schrieb Michael Niedermayer:
> > >>  Makefile |   14 ++++++++++++--
> > >>  1 file changed, 12 insertions(+), 2 deletions(-)
> > >> 47b04de93a2e972467f8f6b6a55e63ac3f570b88  0001-web-Let-the-Makefile-copy-the-website-logo-according.patch
> > >> From 57ab223b421e83f75761bd7d77098bbf5fd5ea84 Mon Sep 17 00:00:00 2001
> > >> From: Thilo Borgmann <thilo.borgmann at googlemail.com>
> > >> Date: Tue, 17 Apr 2012 11:37:53 +0200
> > >> Subject: [PATCH] web: Let the Makefile copy the website logo according to src/logik.
> > > 
> > > has the makefile been tested with all combinations of copy cases ?
> > 
> > Just retestet. Works well for me for none/$(DATE)-standard/$(DATE).png files
> > with and without existing htdocs/ffmpeg-logo.png.
> 
> have the consequences of this being run by a cron job and hook at the
> same time been considered ? that is race conditions ?

The worst that should be possible to happen (assuming we keep the cron
job from running too close to midnight) is that there are two cps
running with same source and destination.
I don't know for sure but I'd expect that should not cause an issue.
(a bigger issue might be the web server reading the file while it's
still being copied, but I don't really think this is relevant either).