[FFmpeg-devel] [PATCH] Add "progressive" to the options that "setfield" can force

[Stefano Sabatini]

On date Friday 2012-04-20 14:39:41 +0100, Tim Nicholson encoded:
> On 20/04/12 12:45, Nicolas George wrote:
> > [..]
> > The usual coding style here is to put the else on the same line as the
> > closing brace (and to put braces on both branches if only one needs it). But
> > it does not matter much.
> >
> 
> Ahh. One of those nuances I didn't spot in the developer guidelines or
> my straw poll of the code. I will try to remember for future
> submissions. Thanks.
> 
> 
> 
> >> +            if (setfield->top_field_first < -1 || setfield->top_field_first > 1) {
> >> +                av_log(ctx, AV_LOG_ERROR,
> >> +                       "Provided integer value %d must be included between -1 and +1\n",
> >> +                       setfield->top_field_first);
> >> +                return AVERROR(EINVAL);
> >> +            }
> >> +            av_log(ctx, AV_LOG_WARNING, "Using -1/0/1 is deprecated, please use auto/tff/bff/prog \n", args);
> > 
> > Is the space before the \n on purpose?
> 
> For me yes, but maybe not for ffmpeg style.. ;(
> 
> > [..]
> > 
> > No more remarks from me, I leave it to Stefano, who knows the filter better.
> > No need to send another patch to address the two trivial remarks above I
> > think.

Applied with a few minor fixes, thanks.
-- 
FFmpeg = Free and Free Mystic Powerful Elected Gospel