[FFmpeg-devel] [PATCH] Fix compilation with NASM.

[Reimar Döffinger]

On Fri, Apr 20, 2012 at 08:03:59PM +0200, Reimar Döffinger wrote:
> On Thu, Apr 19, 2012 at 10:50:12AM +0900, KO Myung-Hun wrote:
> > Hi/2.
> > 
> > Reimar Döffinger wrote:
> > > Signed-off-by: Reimar Döffinger <Reimar.Doeffinger at gmx.de>
> > > ---
> > >  libavutil/x86/x86inc.asm |    7 +++++--
> > >  1 file changed, 5 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/libavutil/x86/x86inc.asm b/libavutil/x86/x86inc.asm
> > > index 7e389d0..1303902 100644
> > > --- a/libavutil/x86/x86inc.asm
> > > +++ b/libavutil/x86/x86inc.asm
> > > @@ -97,7 +97,10 @@
> > >  %endif
> > >  
> > >  ; Always use long nops (reduces 0x90 spam in disassembly on x86_32)
> > > +; Not supported by NASM (except via smartalign package)
> > > +%ifdef __YASM_VER__
> > >  CPU amdnop
> > > +%endif
> > >  
> > 
> > If so, how about using smartaling package ?
> > 
> > +%ifdef __YASM_VER__
> >  CPU amdnop
> > +%else
> > +%use smartalign
> > +ALIGNMODE k7
> > +%endif
> > 
> > Any problem ?
> 
> That I have no idea what that does, and if it is safe to do this
> is the problem.
> So I rather went with the safe approach.

Actually I can answer it more specifically:
Because NASM is broken and only spews out hundreds of errors
as soon as you use smartalign together with the -M option.