[FFmpeg-devel] [PATCH] Add "progressive" to the options that "setfield" can force

Tim Nicholson nichot20 at yahoo.com
Fri Apr 20 09:39:11 CEST 2012


On 18/04/12 17:27, Nicolas George wrote:
> Le decadi 30 germinal, an CCXX, Tim Nicholson a écrit :
>> [...]
>> diff --git a/libavfilter/vf_setfield.c b/libavfilter/vf_setfield.c
>> index bfb8006..6f536a7 100644
>> --- a/libavfilter/vf_setfield.c
>> +++ b/libavfilter/vf_setfield.c
>> @@ -40,17 +40,20 @@ static av_cold int init(AVFilterContext *ctx, const char *args, void *opaque)
>>          if (sscanf(args, "%d%c", &setfield->top_field_first, &c) != 1) {
>>              if      (!strcmp("tff",  args)) setfield->top_field_first = 1;
>>              else if (!strcmp("bff",  args)) setfield->top_field_first = 0;
>> +            else if (!strcmp("prog",  args)) setfield->top_field_first = 2;
>>              else if (!strcmp("auto", args)) setfield->top_field_first = -1;
>>              else {
>>                  av_log(ctx, AV_LOG_ERROR, "Invalid argument '%s'\n", args);
>>                  return AVERROR(EINVAL);
>>              }
>>          }
>> +        else
>> +            av_log(ctx, AV_LOG_WARNING, "Using -1/0/1 is deprecated, please use auto/tff/bff/prog \n", args);
> 
> Unusual indentation.

I thought I had got it right, as it matches elsewhere, but being new to
this I could easily be wrong. Could you be more specific and I will try
and correct it.


> Thanks for your work.

Other points noted, and will have a look at them....

-- 
Tim


More information about the ffmpeg-devel mailing list