[FFmpeg-devel] [patch] Fix a warning in fft_mmx.asm on mac

Nico Weber thakis at chromium.org
Tue Apr 17 21:39:23 CEST 2012


> > > Also if you are concerned about warnings, there are many that can be
> > > removed with less risk and troubble.
> >
> > This is the last warning in all of chromium, including all third-party
>>  code. (Admittedly, we disabled several harmless warnings that ffmpeg
> > doesn't seem to care about in the C parts. This yasm warning can't be
> > disabled though.)
>
> maybe instead of a yes or no to the removial of this code, it could
> just be put under a __YASM_VERSION_ID__ based check ?

That's a good idea. Attached. I ran `make fate` with this change and
verified that all tests still pass (on mac, with yasm 1.2).

Nico
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Remove-.rodata-alignment-kludge-for-Mach-O-if-a-rece.patch
Type: application/octet-stream
Size: 2965 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120417/6f6a2534/attachment.obj>


More information about the ffmpeg-devel mailing list