[FFmpeg-devel] [PATCH] CrystalHD: fix pStride value and set aspect ratio

[Istvan Sebok]

2012. április 16. 20:33 Istvan Sebok írta, <sebok.istvan at gmail.com>:

>
>
> 2012. április 16. 0:49 Reimar Döffinger írta, <Reimar.Doeffinger at gmx.de>:
>
> On Mon, Apr 16, 2012 at 12:18:44AM +0200, Istvan Sebok wrote:
>> > 2012. április 15. 22:48 Reimar Döffinger írta, <
>> Reimar.Doeffinger at gmx.de>:
>> >
>> > > On Sun, Apr 15, 2012 at 09:13:15PM +0200, Istvan Sebok wrote:
>> > > >
>> > >
>> > > A bit more of a description wouldn't hurt.
>> > > Are you absolutely sure the 1080 pStride value actually works?
>> > > 1080 would be a very, very strange value for a supported
>> > > video width.
>> > >
>> >
>> > I didn't add 1080 pStride value I just changed 'else if' order. I have
>> > 70015 card, I can't test it.
>>
>> Well, from the code behaviour point changing the else if order has
>> the same effect as adding it.
>> Without someone to test, removing it would be safer than changing
>> the order.
>>
>>
> OK. I wait few days. If nobody tests it, I will remove these lines and I
> will send a new patch.
>
>
> Scott D. Davilla helped for me, he wrote:

The 70015 card provides a correct stride but the 70012 card is stride
quantized to 720/1280/1920

The new patch fix warning: "'pStride' may be used uninitialized in this
function" too.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-CrystalHD-fix-pStride-value.patch
Type: application/octet-stream
Size: 867 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120417/f81a1896/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-CrystalHD-Set-aspect-ratio.patch
Type: application/octet-stream
Size: 2918 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120417/f81a1896/attachment-0001.obj>