[FFmpeg-devel] [PATCH] web: Copy FFmpeg Logo by Makefile instead of cronjob

[Thilo Borgmann]

Am 14.04.12 18:05, schrieb Reimar Döffinger:
> On Sat, Apr 14, 2012 at 11:46:03AM +0200, Michael Niedermayer wrote:
>> On Wed, Apr 11, 2012 at 12:50:34PM +0200, Thilo Borgmann wrote:
>>>> this will update teh file even if it matches, this breaks caching of
>>>> the logo 
>>>
>>> Updated Patch attached.
>>
>> from a quick look, its ok
>> maybe reimar can double check ?
> 
> I don't see any real issues with it.
> Though if you're pedantic there's a questions whether "test -r" is
> the best condition, copying over the file to my knowledge won't
> fix any permissions which is why I went with -f originally.
> I don't think it really matters, when it makes a different things
> are already seriously broken anyway and will need manual intervention.

I don't really get it.

"test -r" or "test -f" - what does that have to do with fixing permissions?

I think "test -w" would be a good test because the makefile's process also
copies the file and there can only do it if the file is writable.

For fixing permissions, I think, we have to use "cp -f" - my man page says
unlinking is done after copying and thus retaining permissions. So we have to
ensure the correct permissions just once for htdocs/ffmpeg-logo.png.

?

-Thilo