[FFmpeg-devel] [PATCH] h264: assembly version of get_cabac for x86_64 with PIC

Reimar Döffinger Reimar.Doeffinger at gmx.de
Fri Apr 13 19:34:12 CEST 2012


On Fri, Apr 13, 2012 at 04:34:34PM +0200, Roland Scheidegger wrote:
> There are similar functions which could get the same treatment but they
> are less frequently used and since this isn't very nice as we can't use the
> same assembly template focus on this function alone for now.

Huh? The only other ones seem to be decode_significance as far as I can
tell, and the only reason seems to be that they use
BRANCHLESS_GET_CABAC.
Have you tried making them use your BRANCHLESS_GET_CABAC macro?
Code is in libavcodec/x86/h264_i386.h.
since the macros are used multiple times the label might cause issues.
So far that reason and
for better readability it might be better to require the surrounding
code to have such a label instead of having it in the macro?


More information about the ffmpeg-devel mailing list