[FFmpeg-devel] [PATCH] mov: Fix memory leaks on aborted header parsing.

Michael Niedermayer michaelni at gmx.at
Fri Apr 13 12:10:06 CEST 2012


On Thu, Apr 12, 2012 at 05:50:55PM -0700, dalecurtis at chromium.org wrote:
> From: Dale Curtis <dalecurtis at chromium.org>
> 
> If mov_read_header exits under error, the memory allocated is
> not freed.
> 
> Signed-off-by: Dale Curtis <dalecurtis at chromium.org>

i wonder if we can simply call the close for all demuxers in utils.c,
as this likely affects more demuxers
but until thats tested and investigated, ill apply this patch.

thanks

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120413/42842081/attachment.asc>


More information about the ffmpeg-devel mailing list