[FFmpeg-devel] [PATCH] mov: Fix harmless OOB read.

dalecurtis at chromium.org dalecurtis at chromium.org
Fri Apr 13 03:02:33 CEST 2012


From: Dale Curtis <dalecurtis at chromium.org>

Convert key_off initialize to use the same sc->keyframe_count as
used elsewhere in the function.

Signed-off-by: Dale Curtis <dalecurtis at chromium.org>
---
 libavformat/mov.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/libavformat/mov.c b/libavformat/mov.c
index b4ff1df..ce61250 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -1842,7 +1842,7 @@ static void mov_build_index(MOVContext *mov, AVStream *st)
         unsigned int stts_sample = 0;
         unsigned int sample_size;
         unsigned int distance = 0;
-        int key_off = sc->keyframes && sc->keyframes[0] == 1;
+        int key_off = sc->keyframe_count && sc->keyframes[0] == 1;
 
         current_dts -= sc->dts_shift;
 
-- 
1.7.7.3



More information about the ffmpeg-devel mailing list