[FFmpeg-devel] [PATCH] web: Copy FFmpeg Logo by Makefile instead of cronjob

[Thilo Borgmann]

Am 08.04.12 01:13, schrieb Thilo Borgmann:
> Am 08.04.12 00:48, schrieb Reimar Döffinger:
>> On Sun, Apr 08, 2012 at 12:06:44AM +0200, Thilo Borgmann wrote:
>>> +LOGO_SRC := $(wildcard src/logik/$(DATE)-standard)
>>> +
>>> +ifneq ($(LOGO_SRC),)
>>
>> I don't see the point of this indirection, going through LOGO_SRC
>>
>>> +htdocs/ffmpeg-logo.png: $(LOGO_SRC)
>>> +	test -z $< || cp $< $@
>>> +	test ! -z $< || test -r $@ || cp htdocs/FFmpeg_standard.png $@
>>
>> Hm, I don't think the "test ! -z $< ||" makes really sense,
>> just leaving it out IMO gives a more logical behaviour.
>> And maybe comment it, too:
>> # if we have a new source file, copy it over
>> test -z $< || cp $< $@
>> # if not, make sure we have at least some file, otherwise copy default
>> test -r $@ || cp htdocs/FFmpeg_standard.png $@
> 
> I think it's getting clear to be a fallback without the leading "test ! -z"
> 
> All other comments included :)

Everyone is ok with that?

-Thilo