[FFmpeg-devel] [PATCH] web: Copy FFmpeg Logo by Makefile instead of cronjob

[Thilo Borgmann]

Am 07.04.12 20:24, schrieb Michael Niedermayer:
> On Fri, Apr 06, 2012 at 02:11:42PM +0200, Reimar Döffinger wrote:
>> On Fri, Apr 06, 2012 at 01:23:13PM +0200, Thilo Borgmann wrote:
>>> +DATE := $(shell date +%m%d)
>>> +
>>> +LOGO_FILES := $(wildcard src/logik/$(DATE).*)
>>> +
>>> +ifeq ($(LOGO_FILES),)
>>> +LOGO_FILES := $(wildcard src/logik/$(DATE)-standard)
>>> +endif
>>
>> Why not just
>> LOGO_FILES := $(wildcard src/logik/$(DATE).* src/logik/$(DATE)-standard)
>> Though honestly do we have to make it that messy? Why not just
>> making a symlink to htdocs/FFmpeg_standard.png instead of needing
>> special-casing for -standard?
>> Otherwise another option is to use
>>> +ifneq ($(wildcard src/logik/$(DATE)-standard),)
>>> +LOGO_FILES := htdocs/FFmpeg_standard.png
>>> +endif
>>
>>
>>> +src/logik/$(DATE)-standard:
>>> +	cmp cp htdocs/FFmpeg_standard.png htdocs/ffmpeg-logo.png || \
>>> +	cp htdocs/FFmpeg_standard.png htdocs/ffmpeg-logo.png
>>> +
>>> +src/logik/$(DATE).png:
>>> +	cmp $@ htdocs/ffmpeg-logo.png || cp $@ htdocs/ffmpeg-logo.png
>>
>> There is a "cp" too much in the first one.
> 
>> Also this looks like blatant misuse of the make syntax.
> 
> i agree

okok, here it comes as its diverged from non-phony usage for the hovertext anyway:
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-Let-the-Makefile-copy-the-website-logo-according-to-.patch
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120408/85984623/attachment.ksh>