[FFmpeg-devel] [PATCH] ffprobe: use avbprint API

[Nicolas George]

Le nonidi 19 germinal, an CCXX, Stefano Sabatini a écrit :
> Simplify, increase robustness.
> ---
>  ffprobe.c |  265 +++++++++++++++++++------------------------------------------
>  1 files changed, 81 insertions(+), 184 deletions(-)

It looks correct.

Some code could probably be factored, but this is completely unrelated.

> +    for (p = src; *p; p++) {
>          if (*p == '"')
> -            *q++ = '\"';
> -        *q++ = *p++;
> +            av_bprint_chars(dst, '\"', 1);

For CSV, shouldn't \ itself be escaped too? This is unrelated too, though.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120407/99b30f2e/attachment.asc>